review-3.md
c10 · Review stop 3
Branch claude/guide-walk-fixes-f9dd48, the commit after 2045243. Not pushed, not merged. This answers Mark's capture of the tour picker on 2045243 running live (his capture), sent by the walk session.
Whether it predates c10
It does. The menu (view::menu) has been unchanged since c2's Tour stretch (9d37433, 2026-11-11). It was always a fixed 320 px wide, its words never wrapped, and it had the panel's own ground with no edge.
Two later changes made the flaws show:
- e4fc308's undocked panel is 380 px wide, so the overflowing words now land on the page.
- c10's synthetic note sits right under the menu.
The note didn't really show through the menu. The menu was narrower than the panel and had no edge, so the note's corner and last lines sat just outside it and read as if under it.
What changed
Docked, light · docked, dark · undocked, light · undocked, dark.
- One surface.
- The menu is the kit's raised surface (white in light, #111 in dark) with the panel's hairline, a deeper shadow and radius 10 from the token scale.
- It's the panel's last child, so it paints over the body and footer, and it keeps clicks and the wheel to itself.
- As wide as the panel. It runs 16 px in from each edge, docked or undocked.
- Words wrapped inside it. Each item's name and line wrap within the item. The longest lines take a second line at the undocked width.
- The highlight is the whole item, edge to edge.
- No repeated name. The line under each name is the title without the name it repeats (
view::menu_line):- "What it does on your machine, what it records, and how it reaches you"
- "The AI tools here, what they use and where they work"
- "Played as a simulation"
Tests
the_tour_menu_keeps_its_words_inside_the_panel, docked and undocked:- an item per tour, each inside the panel's bounds;
- no line repeating its name;
- wrapping at the undocked width;
menu_line's three cases.
- Stories
app-tour-menuandapp-tour-menu-undocked, light and dark.
The test reads the items' boxes, not the pixels. A first try that deferred the menu's paint recorded the boxes but drew nothing, and only the capture caught it, so the captures are the check for paint.
For Mark
- Under "Simulation · Phishing for financial records", the line now reads only "Played as a simulation". The alternative is the tour's stop questions, which run to four or six per tour; I kept the shorter line.